Conversation
The musl baseline for Rust is 1.2.5 since 1.93.0. Therefore, it is safe to make rustc-dep-of-std imply musl_v1_2, and this lets us start using statx from libc in std.
tgross35
requested changes
Aug 30, 2026
Member
There was a problem hiding this comment.
The change here looks fine to me, though a comment in Cargo.toml would be helpeful. However, I'd rather not merge this until there's a rust-lang/rust PR setting this cfg via bootstrap and doing try jobs on our musl targets. That won't be the permanent of course, but I would be better to find anything broken and fix it without needing to ping pong between libc releases and rustc PRs.
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
tgross35
added
the
stable-nominated
Collaborator
|
☔ The latest upstream changes (possibly #5508) made this pull request unmergeable. Please resolve the merge conflicts. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The musl baseline for Rust is 1.2.5 since 1.93.0. Therefore, it is safe to make rustc-dep-of-std imply musl_v1_2, and this lets us start using statx from libc in std.